Silence error on migration 4736ec66ce19 constraint drop #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5729 +/- ##
=========================================
Coverage ? 63.43%
=========================================
Files ? 362
Lines ? 22983
Branches ? 2557
=========================================
Hits ? 14580
Misses ? 8388
Partials ? 15Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Aug 28, 2018
| logging.warning( | ||
| "Constraint drop failed, you may want to do this " | ||
| "manually on your database. For context, this is a known " | ||
| "issue around undeterministic contraint names on Postgres " |
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* Silence error on migration 4736ec66ce19 constraint drop * typo + lint
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Silence error on migration 4736ec66ce19 constraint drop * typo + lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5728